embassy icon indicating copy to clipboard operation
embassy copied to clipboard

Add block-device-driver impl for use with embedded-fatfs

Open MabezDev opened this issue 1 year ago • 1 comments

I'm slowly working towards the first embedded-fatfs release! The biggest changes have been that the device trait and helpers are now outside of embedded-fatfs itself. This means I can

  • PR impls before releasing embedded-fatfs
  • make breaking changes in embedded-fatfs without making HAL implementors update
  • the block device is now more useful outside of embedded-fatfs, for instance someone could use these building blocks to implement another filesystem, or even there own.

This PR is mostly inert, but if you'd like to try it out you can use the esp32c6 example I have in embedded-fatfs proper, which you can use a reference to craft an stm example. I have tested with my project and once embedded-fatfs has a release I plan on adding a stm32f2 example either here or in embedded-fatfs.

MabezDev avatar Feb 21 '24 00:02 MabezDev

This PR has been updated to use a new, but unreleased version of block-device-driver which includes buffer alignments within the trait itself https://github.com/MabezDev/embedded-fatfs/pull/23.

Release of the new version is blocked on https://github.com/japaric/aligned/pull/18.

MabezDev avatar Feb 22 '24 22:02 MabezDev

is this still draft for a reason?

Dirbaio avatar Aug 26 '24 15:08 Dirbaio

is this still draft for a reason?

I had some issues using embassy main in my project, but I've recently sorted those and can confirm this PR works as expected now :D

MabezDev avatar Aug 26 '24 17:08 MabezDev

:rocket:

Dirbaio avatar Aug 26 '24 18:08 Dirbaio

manually stomping over spurious failure

Dirbaio avatar Aug 26 '24 18:08 Dirbaio