embassy icon indicating copy to clipboard operation
embassy copied to clipboard

Published 20 hours ago • verified publisher icon embassy-rs

embassy-usb modifications

Open pcbzzz opened this issue 2 years ago • 1 comments

BosWriter doesn't write valid attributes, seems like it was just added as an example. BOS needs more data than is currently being passed to the builder, so I don't think it's even really necessary as a builder param until it's more flushed out. Though I've left is as optional for now.

pcbzzz avatar May 30 '23 01:05 pcbzzz

I'm not sure making the BOS descriptor optional is the best approach. While it's not required for USB 2.0 devices it is required in later editions of the spec and it is being used for various extensions. For example, the MSOS descriptors feature needs to write a BOS capability. If the BOS descriptor is optional that could lead to a runtime panic in the case that someone using the msos-descriptor feature tries to write a MSOS descriptor while passing None for the BOS descriptor buffer.

alexmoon avatar May 30 '23 15:05 alexmoon

closing due to staleness.

  • The HID protocol seems a useful addition, feel free to repoen a PR with just that.
  • I'm not sure about the BOS thing.

Dirbaio avatar Dec 03 '24 00:12 Dirbaio