embark icon indicating copy to clipboard operation
embark copied to clipboard

fix(@embark/whisper): p2p port is main command

Open 3esmit opened this issue 5 years ago • 2 comments

What did you refactor, implement, or fix?

Port was never being defined for whisper, because it never called the rpc port config. This commit moves port flag to the main commands, so it's always included.

How did you do it?

Just moved where the flag is included.

Is there anything that needs special attention (breaking changes, etc)?

No

Questions

Can we make p2p port part of main commands of embark/geth as well?

Cool Spaceship Picture

image

3esmit avatar Aug 07 '20 14:08 3esmit

Done

3esmit avatar Aug 11 '20 01:08 3esmit

Please, merge.

3esmit avatar Sep 23 '20 19:09 3esmit