Emanuele Sabellico
Emanuele Sabellico
@milindl sent a commit, please check again
Yeah, we need to add a test run with classic + kraft. Currently if make `testConsumerGroupProtocolClassic` return `false` and run it without TEST_CONSUMER_GROUP_PROTOCOL they pass. We shouldn't have a flag...
Hi, even if you're using a custom delivery report channel you should still poll from the Events channel for other events https://github.com/confluentinc/confluent-kafka-go/blob/d194ad14d58e17147c529ac4715850ca0a62134c/examples/producer_example/producer_example.go#L51
Thank you all for raising awareness on this issue. > So I think what happened is that @emasab who [built librdkafka for 2.3.0](https://github.com/confluentinc/confluent-kafka-go/commit/954a98de88c90692584fb0e48853e80cc05e04a1) happens to have Cyrus SASL/libsasl2 installed in...
> Then we import those binaries locally to push them to confluent-kafka-go. There's room for security improvements here. We have to make this step run on CI too.
`v2.1.1-linux-arm64-musl` isn't affected either. But better to use the workaround at take latest fixes in 2.3.0 at the moment.
Confirmed that the only affected ones are these ones, by looking for `rdkafka_sasl_cyrus.o` in archive files. - v2.1.0-linux-arm64-musl - v2.3.0-linux-arm64-musl
Raised this [PR](https://github.com/confluentinc/librdkafka/pull/4666). And confirmed that the produced binaries don't include `rdkafka_sasl_cyrus.o`, except for `darwin` where it's expected to have it.
Hello @Quuxplusone , thanks for investigating this issue, the solution isn't reverting the commit as you see there were failing tests that were fixed. The `rd_kafka_toppar_destroy` is usually called [here](https://github.com/confluentinc/librdkafka/blob/d7428d052a235aa23e291fc26d96e763985648fb/src/rdkafka_op.c#L478)....