FireflyMobile icon indicating copy to clipboard operation
FireflyMobile copied to clipboard

Migration to Android 13

Open ArnyminerZ opened this issue 2 years ago • 4 comments

Type of change

  • [ ] Bug fix
  • [x] New feature
  • [ ] Translation

Migrations made

  • Location permissions change (Android 12 - Docs).
  • Updated AGP to 7.3.1
  • Updated target and compile SDK to 33
  • Updated to Gradle 7.4
  • Using per-app language preferences (Android 13 - Docs)
  • Updated dependencies

ArnyminerZ avatar Nov 24 '22 19:11 ArnyminerZ

Hi, thanks for your contribution. This is quite a big MR. I am hesistant to merge it without doing a thorough review of the commits. I will merge this in due time.

emansih avatar Nov 27 '22 10:11 emansih

I'll use this as a daily driver, to check if it has any major issues.

ArnyminerZ avatar Nov 28 '22 10:11 ArnyminerZ

Hi @ArnyminerZ . I pulled your changes to my local machine and I can't build it.

e: C:\FireflyMobile\app\src\main\java\xyz\hisname\fireflyiii\workers\AttachmentWorker.kt: (49, 58): Cannot access class 'com.google.common.util.concurrent.ListenableFuture'. Check your module classpath for missing or conflicting dependencies e: C:\FireflyMobile\app\src\main\java\xyz\hisname\fireflyiii\workers\AttachmentWorker.kt: (49, 140): Unresolved reference. None of the following candidates is applicable because of receiver type mismatch: public operator fun MatchGroupCollection.get(name: String): MatchGroup? defined in kotlin.text

emansih avatar Dec 16 '22 08:12 emansih

Yup, Guava is giving problems. Sometimes it does build, other times it just doesn't. I've tried different approaches, there's even a package Google released exclusively for this fix, but nothing works all the times :/

I was waiting for Google to release a fix.

ArnyminerZ avatar Dec 16 '22 09:12 ArnyminerZ