FireflyMobile icon indicating copy to clipboard operation
FireflyMobile copied to clipboard

Buitin calculator not using locale-specific decimal separator settings

Open AlexFullmoon opened this issue 4 years ago • 6 comments

Firefly III Server Version: 5.3.3 (docker)

Firefly III Mobile Version: 3.0.4

Android Version: 10

Device Information: Samsung Galaxy Note9


Wrong decimal separator in builtin calculator when adding a transaction. I use Russian locale with comma as decimal separator and nothing as thousands separator. Calculator uses default English settings with dot as decimal and comma as thousands separators.

Expected Behavior

Chosen locale settings in the calculator.

Current Behavior

Default English locale in the calculator.

Steps to Reproduce

Set currency and locale to Russian on server. Set language to Russian in mobile app. Try to enter transaction with arbitrary value in calculator, for example 1999,99. Calculator will show 1,999.99 which will not be accepted.

AlexFullmoon avatar Sep 27 '20 10:09 AlexFullmoon

just to be clear, are you saying 1,999.99 or 1999,99 cannot be submitted?

emansih avatar Sep 27 '20 23:09 emansih

Currently set (Russian) locale accepts only 1999,99 format (with these server settings). Attempting to enter 1999,99 in calculator results in 1,999.99, which gives noncritical error when submitting transaction, as expected (sorry, my server is down right now, can't check what it says. Something like "wrong amount")

To be clear, that error message is expected behaviour. The problem is that calculator doesn't respect locale settings.

AlexFullmoon avatar Sep 27 '20 23:09 AlexFullmoon

oh i get what you mean. will look into it.

emansih avatar Sep 28 '20 12:09 emansih

That's why I don't use locales other than US. @emansih when the next release will be available?

ivanboytsov avatar Sep 29 '20 19:09 ivanboytsov

When I'm free at the mid of next month.

emansih avatar Sep 30 '20 03:09 emansih

Hi! I am back working on this project. I was testing on Firefly III demo website. I have Russian ruble as the default currency but I am unable to add a transaction with the amount of 1999,99. Is it working as intended?

emansih avatar Oct 23 '20 10:10 emansih