Etienne Magnier

Results 127 comments of Etienne Magnier

I'm not sure to understand this issue. Should `corpusChristiOnSunday` be set to `true` or `false` by default in the GRC?

So all of these properties should be set to `false` by default, from the GRC: https://github.com/romcal/romcal/blob/a82c81d05b658f037f9035011cb6dd9793d65f60/lib/general-calendar/proper-of-saints.ts#L13-L17 --- Additional note to myself: > The `ParticularConfig` in`proper-of-saints.ts` should be removed, because it...

I don't remember what I meant here for the note to myself. It's been several months since I've worked in the codebase, so I'll have to make time for that....

What is the motivation behind that ? And it's not only for l10n, but also for liturgical day, calendar, martyrology items...

I agree to change them to `id`.

Since I still haven't had any answers after a few months, and because it might be only a Fluent syntax issue (rather than a JavaScript issue), I've reposted this issue...

Would it be possible to merge this initial work stage, even if there are still some points to verify or improve? Or do we try to have at least the...

@tukusejssirs absolutely no pressure. I just wanted to follow up here and get an update on the status. If time is limited, I'd suggest considering breaking down the work into...

@tukusejssirs as I said, absolutely no pressure. If you can provide updates within a week, that's great! If it takes more time, that's perfectly fine too 👍 And it's great...

Yes, it seems there is an issue in the regex. The monorepo branch you are mentioning is out of date, so do not consider it (I'll share something when things...