rubyfunctions icon indicating copy to clipboard operation
rubyfunctions copied to clipboard

Published 20 hours ago • verified publisher icon emad-elsaid

Add pagination instead of limiting records

Open ahmadabdelhalim opened this issue 4 years ago • 3 comments

  • Problem The records are limited to a fixed number.

  • Solution Add pagination using the Pagy gem. (I chose it because it's faster than other gems available)

ahmadabdelhalim avatar Apr 13 '20 15:04 ahmadabdelhalim

There is pagination implemented in user page to show more of his functions and saved functions, that could be also used in the timelines controller

On Mon, Apr 13, 2020, 5:18 PM ahmadabdelhalim [email protected] wrote:

Problem The records are limited to a fixed number.

Solution Add pagination using the Pagy gem. (I chose it because it's faster than other gems available)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/emad-elsaid/rubyfunctions/issues/48, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANJAZBEROJZHTUXHFUC2TRMMUM7ANCNFSM4MHAXWYA .

emad-elsaid avatar Apr 13 '20 23:04 emad-elsaid

Yeah, didn't notice that. I can add it to the timelines controller as well.

ahmadabdelhalim avatar Apr 15 '20 13:04 ahmadabdelhalim

@ahmadabdelhalim nice, I'll wait for a PR then :smiley:

emad-elsaid avatar Apr 16 '20 10:04 emad-elsaid