helm-swoop New faces

Thanks for this revolutionizing way to search for expressions throughout our buffers...

Here a feature request: could we have an extra face

for line numbers in the Swoop window?
for target words not in the highlighted line?

See http://screencast.com/t/YV71bHU6ui for an illustration.

Thanks.

Sep 26 '14 08:09 fniessen

Thank you for the request with the lucid illustration.

It's a nice to slightly discriminate faces between on and off the target-line. As to the face of line numbers, it could slow down the performance but it's also nice to add it as an option. I will add those changes on the next update.

Thanks.

Oct 17 '14 15:10 ShingoFukuyama

Thanks!

Oct 17 '14 15:10 fniessen

Is this feature still considered? Are you interested in PRs for this and in general for the issues marked with "feature request"?

May 13 '20 16:05 palikar

Is this feature still considered? Are you interested in PRs for this and in general for the issues marked with "feature request"?

Any PR welcome ;)

May 13 '20 16:05 cireu

This issue seems to be already solved. There are custom variables for the suggested faces

(defcustom helm-swoop-use-line-number-face nil ... ) 
...
(defcustom helm-swoop-line-number-face ... )
(defcustom helm-swoop-target-word-face ...)
(defcustom helm-swoop-target-line-face ...)

To note is that for those to be used, one must set the custom variable helm-swoop-speed-or-color to non-nil.

May 14 '20 13:05 palikar