auto-rename-tag icon indicating copy to clipboard operation
auto-rename-tag copied to clipboard

Published 20 hours ago • verified publisher icon emacs-vs

Rename only happens in post-command and recursion is prevented

Open aaronjensen opened this issue 4 years ago • 3 comments

Fixes #9

This may fix the issues you were seeing, it was possible for infinite recursion to happen which cause a stack error. This should prevent that.

aaronjensen avatar May 20 '20 10:05 aaronjensen

The major issue is when I try to delete the whole word, it wouldn't delete the tag (whole word). Would it delete the whole word on your side? Thanks!

jcs090218 avatar May 20 '20 10:05 jcs090218

It does for me, yes. Can you provide an example that does not currently work for you with this branch?

aaronjensen avatar May 20 '20 10:05 aaronjensen

@jcs090218 give this a shot. It's quite possibly a very bad idea.

The other thing to try is to stash the changes we want to make somewhere during after-change and then apply them during the next post-command, which was the suggestion here: https://github.com/emacs-lsp/lsp-mode/issues/1704#issuecomment-630904219

aaronjensen avatar May 21 '20 06:05 aaronjensen