typescript.el icon indicating copy to clipboard operation
typescript.el copied to clipboard

Comint regexps are incorrect(?)

Open JordanAnthonyKing opened this issue 1 year ago • 5 comments

Comint mode includes the 'Error: ' part of the message in the path when trying to navigate to the file meaning that the file can't be automatically opened, and must be browsed to manually. This is running an npm build.

image

I've verified that only typescript related regexps are present in compilation-error-regexp-alist-alist

image

JordanAnthonyKing avatar Jul 25 '24 13:07 JordanAnthonyKing

Hey there and thanks for the bug-report!

Could you create a minimal GitHub repo with a project which demonstrates this behaviour? :)

If you have that, I'm sure I can try to fix up the compilation-mode regexps to avoid this error.

Also: Please note this major-mode is getting superceded by typescript-ts-mode as part of Emacs 29 and newer 😄

josteink avatar Jul 31 '24 12:07 josteink

I'm aware it's getting superceded, but after it does what's happening to the extra integrations like this?

JordanAnthonyKing avatar Jul 31 '24 13:07 JordanAnthonyKing

If it works, I see no reason not to add it to Emacs core 😉

josteink avatar Jul 31 '24 13:07 josteink

Could you create a minimal GitHub repo with a project which demonstrates this behaviour? :)

Bump

josteink avatar Aug 05 '24 07:08 josteink

Sorry, I've been meaning to get around to this. Would it not be easier to just provide some standard messages and just run the regex against them?

JordanAnthonyKing avatar Aug 05 '24 14:08 JordanAnthonyKing