ts-comint icon indicating copy to clipboard operation
ts-comint copied to clipboard

Issues at printing some symbols

Open touxstone opened this issue 5 years ago • 1 comments

Hi, I was testing this gorgeous contribution (I knew about this package from playing with js-comint on javascript buffers) and I've just found issues when printing, for instance, in the example below, the pound simbol £ though only when working on EMACS. Trying the same example with tsun on the command line it renders as expected. Any help or clue ??. I'd appreciate it.


    function dctoVip(x) {
        return x > 20 ? `Yes!! you got 20% OFF, so only have to pay £${x - x * 0.20}` :
            `Thanks very much! Shop for additional £{20 - x} and you will get 20% discount??`
    }
// testing for instance a shopping of £15
    console.log(dctoVip(15))
//output I got 
// >> Thanks very much! Shop for additional 5 and you will get 20% discount

output expected:

Thanks very much! Shop for additional **£**5 and you will get 20% discount

touxstone avatar May 07 '20 18:05 touxstone

Hey there and thanks for the report.

I honestly don't use this mode that much anymore, and have mostly moved to unit-testing to check correct understanding of smaller bits of code.

That said, are you sure your sample is correct?

This looks like a typo:

`Yes!! you got 20% OFF, so only have to pay £${x - x * 0.20}`

vs

`Thanks very much! Shop for additional £{20 - x} and you will get 20% discount??`

Notice one has £$ while the other only has £. Is this intentional? Are you missing a $ there? If you are, that is a TypeScript syntax-error as far as I can tell.

josteink avatar May 14 '20 08:05 josteink