tree-sitter-langs
tree-sitter-langs copied to clipboard
Add Elixir highlight query
These changes update tree-sitter-elixir to the latest commit and add syntax highlight query. The query copied from upstream repo plus some modification to make it work on this package.
Thanks for the initiative, and sorry for not looking into this earlier.
Can you modify the patterns to follow these principles?
Thanks for the initiative, and sorry for not looking into this earlier.
Can you modify the patterns to follow these principles?
Sure! I will take a look after new year. :)
Just wanted to come round and say I forked this PR branch and have been using it for a few months with no noticeable issues.
When this well merge?
any plan to add sigil support for this scheme or add support for polymode or mmm-mode to get support for more than one type off buffers this could help with org mode or web mode get multi language highlight in one buffer maybe could improve tree sitter experience to be like neovim
Hi,
Sorry for keeping this late. I just got a few updates:
- Update tree-sitter-elixir to latest version.
- Update query and make it conform with elisp-tree-sitter.
Here's some screenshot in tree-sitter-elixir repository:
![Screen Shot 2565-07-11 at 21 36 11](https://user-images.githubusercontent.com/484530/178291209-b7d9fdfd-aaac-407b-9ad4-763e14294b84.png)
![Screen Shot 2565-07-11 at 21 36 29](https://user-images.githubusercontent.com/484530/178291234-a4735f86-070a-4166-bf97-38967f29ee07.png)
![Screen Shot 2565-07-11 at 21 40 46](https://user-images.githubusercontent.com/484530/178291246-df2e514e-2319-499e-9cca-020f2229f630.png)
If you have any suggestions, feel free to comment (and mention me).
@ubolonton Please kindly review again. 🙇
@rodrigues I've apply some patch from you including some fixes. If you try and see something wrong, please ping me. ^^
could anyone explain why this failed becuase it works fine on my machine
could anyone explain why this failed becuase it works fine on my machine
@mohammedzeglam-pg It seems the CI fails during fetch & building grammars.
Updates:
- function declaration and function call now separate query. So it will show different color.
![Screen Shot 2565-07-12 at 11 37 09](https://user-images.githubusercontent.com/484530/178409791-a19a26f9-66b7-4c65-8aa2-095904b14813.png)
@wingyplus if you can help figure out what is happening in CI. I can get this merged in 🎉
@wingyplus if you can help figure out what is happening in CI. I can get this merged in 🎉
Thank you. I’ll find the time to make ci happy. ^^
Hi, pardon for possibly stupid question, but does this also correctly highlight HTML within ~H sigil?
Hi, pardon for possibly stupid question, but does this also correctly highlight HTML within ~H sigil?
Nope. It doesn’t support language injector by the package.
Nope. It doesn’t support language injector by the package.
Thanks! Another noob question, what will it take to make that work? Is it even possible to make the highlights within sigils work?
Now that Azure CI has been removed. @wingyplus can you rebase off master and see if we get CI passing?
Nope. It doesn’t support language injector by the package.
Thanks! Another noob question, what will it take to make that work? Is it even possible to make the highlights within sigils work?
for this you need tree-sitter to support multi-document like nvim do with inject files, if emacs-treesitter support thing like this you will see these changes became a thing but maybe if you want to see thing do it see tsx-mode.
I've tested this locally by rebasing master and updating the elixir submodule to the latest commit and it all seems to work well 🎉
If a collaborator is interested in taking this over, it shouldn't require much (if any) work
@jsmestad Sorry for late response. I rebase it already. 🙇
@jsmestad Could you rebase once more on top of master, there was an issue unrelated to this PR breaking the CI. Looks good otherwise.
I think this can be closed since #174 is already merged.