tree-sitter-langs icon indicating copy to clipboard operation
tree-sitter-langs copied to clipboard

Add Elixir highlight query

Open wingyplus opened this issue 2 years ago • 13 comments

These changes update tree-sitter-elixir to the latest commit and add syntax highlight query. The query copied from upstream repo plus some modification to make it work on this package.

wingyplus avatar Dec 11 '21 08:12 wingyplus

Thanks for the initiative, and sorry for not looking into this earlier.

Can you modify the patterns to follow these principles?

ubolonton avatar Dec 29 '21 17:12 ubolonton

Thanks for the initiative, and sorry for not looking into this earlier.

Can you modify the patterns to follow these principles?

Sure! I will take a look after new year. :)

wingyplus avatar Dec 30 '21 02:12 wingyplus

Just wanted to come round and say I forked this PR branch and have been using it for a few months with no noticeable issues.

ZachFontenot avatar Apr 07 '22 17:04 ZachFontenot

When this well merge?

mohammedzeglam-pg avatar Apr 10 '22 17:04 mohammedzeglam-pg

any plan to add sigil support for this scheme or add support for polymode or mmm-mode to get support for more than one type off buffers this could help with org mode or web mode get multi language highlight in one buffer maybe could improve tree sitter experience to be like neovim

mohammedzeglam-pg avatar Apr 23 '22 23:04 mohammedzeglam-pg

Hi,

Sorry for keeping this late. I just got a few updates:

  • Update tree-sitter-elixir to latest version.
  • Update query and make it conform with elisp-tree-sitter.

Here's some screenshot in tree-sitter-elixir repository:

Screen Shot 2565-07-11 at 21 36 11 Screen Shot 2565-07-11 at 21 36 29 Screen Shot 2565-07-11 at 21 40 46

If you have any suggestions, feel free to comment (and mention me).

wingyplus avatar Jul 11 '22 14:07 wingyplus

@ubolonton Please kindly review again. 🙇

wingyplus avatar Jul 11 '22 14:07 wingyplus

@rodrigues I've apply some patch from you including some fixes. If you try and see something wrong, please ping me. ^^

wingyplus avatar Jul 11 '22 15:07 wingyplus

could anyone explain why this failed becuase it works fine on my machine

mohammedzeglam-pg avatar Jul 11 '22 17:07 mohammedzeglam-pg

could anyone explain why this failed becuase it works fine on my machine

@mohammedzeglam-pg It seems the CI fails during fetch & building grammars.

wingyplus avatar Jul 12 '22 02:07 wingyplus

Updates:

  • function declaration and function call now separate query. So it will show different color.
Screen Shot 2565-07-12 at 11 37 09

wingyplus avatar Jul 12 '22 04:07 wingyplus

@wingyplus if you can help figure out what is happening in CI. I can get this merged in 🎉

jsmestad avatar Sep 19 '22 17:09 jsmestad

@wingyplus if you can help figure out what is happening in CI. I can get this merged in 🎉

Thank you. I’ll find the time to make ci happy. ^^

wingyplus avatar Sep 21 '22 19:09 wingyplus

Hi, pardon for possibly stupid question, but does this also correctly highlight HTML within ~H sigil?

bhankas avatar Oct 17 '22 13:10 bhankas

Hi, pardon for possibly stupid question, but does this also correctly highlight HTML within ~H sigil?

Nope. It doesn’t support language injector by the package.

wingyplus avatar Oct 17 '22 14:10 wingyplus

Nope. It doesn’t support language injector by the package.

Thanks! Another noob question, what will it take to make that work? Is it even possible to make the highlights within sigils work?

bhankas avatar Oct 18 '22 15:10 bhankas

Now that Azure CI has been removed. @wingyplus can you rebase off master and see if we get CI passing?

jsmestad avatar Oct 20 '22 20:10 jsmestad

Nope. It doesn’t support language injector by the package.

Thanks! Another noob question, what will it take to make that work? Is it even possible to make the highlights within sigils work?

for this you need tree-sitter to support multi-document like nvim do with inject files, if emacs-treesitter support thing like this you will see these changes became a thing but maybe if you want to see thing do it see tsx-mode.

mohammedzeglam-pg avatar Oct 21 '22 13:10 mohammedzeglam-pg

I've tested this locally by rebasing master and updating the elixir submodule to the latest commit and it all seems to work well 🎉

If a collaborator is interested in taking this over, it shouldn't require much (if any) work

gf3 avatar Jan 05 '23 21:01 gf3

@jsmestad Sorry for late response. I rebase it already. 🙇

wingyplus avatar Jan 06 '23 14:01 wingyplus

@jsmestad Could you rebase once more on top of master, there was an issue unrelated to this PR breaking the CI. Looks good otherwise.

meain avatar Jan 14 '23 05:01 meain

I think this can be closed since #174 is already merged.

jcs090218 avatar Sep 02 '23 20:09 jcs090218