lsp-ui icon indicating copy to clipboard operation
lsp-ui copied to clipboard

Published 20 hours ago • verified publisher icon emacs-lsp

Add posframe integration to lsp-ui-doc

Open ericdallo opened this issue 3 years ago • 8 comments

Another try to https://github.com/emacs-lsp/lsp-ui/pull/459 which was reverted

  • Fix when to hide window
  • Address https://github.com/emacs-lsp/lsp-ui/pull/465

lsp-ui-doc-posframe

ericdallo avatar Aug 01 '20 18:08 ericdallo

@Sorixelle created this PR trying to fix some issues, we should merge that when we confirm that the issues reported before are fixed. It works ok for my NixOS - bspwm window manager. We should try with xmonad users and macos users who reported issues with mouse hover.

ericdallo avatar Aug 01 '20 21:08 ericdallo

Merge ?

brotzeit avatar Aug 07 '20 12:08 brotzeit

I think that all that complained in #465 should test that.

(@seagle0128 was one of them)

yyoncho avatar Aug 07 '20 12:08 yyoncho

Yes, I tested it on NixOS (bspwm window manager), but it would be better to test on macOS and gnome that had issues.

ericdallo avatar Aug 07 '20 14:08 ericdallo

It works fine on gnome2.

yyoncho avatar Aug 07 '20 14:08 yyoncho

I tested on macOS. It's not working well. The screenshot is below.

image

The original is image

seagle0128 avatar Aug 07 '20 15:08 seagle0128

Can this one be merged yet?

kiennq avatar Aug 18 '20 02:08 kiennq

We need to fix @seagle0128 bug or ask for more people to test it, I think

ericdallo avatar Aug 18 '20 12:08 ericdallo