lsp-mode icon indicating copy to clipboard operation
lsp-mode copied to clipboard

Switch tool detection for lsp-unzip (#3022)

Open Horrih opened this issue 1 year ago • 4 comments

It caused issues on windows if unzip was found on the PATH, because it fell back to the bash command + unzip.

Changing in order of detection fixes the issue.

Horrih avatar Jun 09 '24 06:06 Horrih

This will force powershell on linux which IIRC was causing trouble in the past. Can you add additional condition (if on windows and if powershell there - use it)

yyoncho avatar Jun 09 '24 18:06 yyoncho

Just pushed a new version, is this what you had in mind ? Just checked it on both my systems, it seems to work fine.

Btw, thanks a lot for your selfless work on lsp-mode. Lsp-mode is the sole reason I came back to emacs in 2019 years after I gave up on the tags system.

Horrih avatar Jun 09 '24 19:06 Horrih

((executable-find "powershell") lsp-ext-pwsh-script

can you keep that too in the end?

yyoncho avatar Jun 10 '24 05:06 yyoncho

Sure, is that better ?

I rebased onto master + squashed the previous commits

Horrih avatar Jun 10 '24 19:06 Horrih

LGTM! Thank you for taking care of this!

jcs090218 avatar Sep 30 '24 18:09 jcs090218