lsp-mode
lsp-mode copied to clipboard
emacs-lsp
Astro language server not showing in lsp-install-server
Thank you for the bug report
- [X] I am using the latest version of
lsp-moderelated packages. - [X] I checked FAQ and Troubleshooting sections
- [X] You may also try reproduce the issue using clean environment using the following command:
M-x lsp-start-plain
Bug description
When trying to install the Astro language server through lsp-install-server, astro-ls does not show up. According to @hlissner on the Doom Emacs discord, it's because there is no configuration in lsp-astro.el. (source)
Steps to reproduce
- Install
lsp-mode - Run
lsp-install-server - Search for
astro-ls - No entry
Expected behavior
astro-lsshould show in the list of servers, as stated in the documentation page
Which Language Server did you use?
astro-ls
OS
MacOS
Error callstack
No response
Anything else?
I also got this error, but I'm not sure it's related to this issue.
../.emacs.d/.local/straight/build-29.1/lsp-mode/lsp-mode.el: Warning: Non-symbol arguments to cl-defgeneric: (process process) [5 times]
To spare you the trouble of hunting on our Discord server, these were my observations: the client defined in clients/lsp-astro.el lacks a :download-server-fn property and/or a lsp-dependency declaration (which I assume is the bare minimum needed for a client to show up in M-x lsp-install-server). Yet, lsp-mode's docs for Astro suggest astro-ls is installable via M-x lsp-install-server.
Yeah, @hlissner is correct, tagging latest people that worked on that support: @tian-yi @lucafanselau @pawelkobojek. @bustinbung feel free to open PRs if you know how lsp-mode can install astro
Bumping this issue. Will look into PRing an installer, but at the very least, misleading docs should be addressed
Anyone know how to install? I'm happy to update docs. Do I just... pop this PR code into my config or something? https://github.com/emacs-lsp/lsp-mode/pull/3816
