emacs-lsp
Update default jdtls version from 1.12.0 -> 1.14.0
This PR updates the defaults value of lsp-java-jdt-download-url to point to the newest version of jdtls from https://download.eclipse.org/jdtls/milestones
Can you check if that version works fine with the java debug plugin we are downloading?
Yes, for sure, I'm doing some manual testing ATM, will get back after I've tried out the debugger
Due to https://github.com/eclipse/eclipse.jdt.ls/pull/2141, this update requires java 17 now. Which is probably a good thing due to a pretty severe CVE found in April 2022.
Yes, for sure, I'm doing some manual testing ATM, will get back after I've tried out the debugger
Due to eclipse/eclipse.jdt.ls#2141, this update requires java 17 now. Which is probably a good thing due to a pretty severe CVE found in April 2022.
Then I would like to have some kind of interactiveness here. Like: check if the user is on java 17. If they are not suggest they migrate to it, and if they don't: download a version that works with 11. If we don't do that lsp-java will get tons of bug reports, reddit posts, etc.
and if they don't: download a version that works with 11
and of course, warn them about that issue.
Hmm, yeah okay, that's one way to go down.. Another option is to update the README, so potential new users are aware that lsp-java currently needs Java 17 >=, however, if they really want to use a previous version of Java they can customize lsp-java-jdt-download-url before installing the language server.
This patch wouldn't affect current lsp-java users, unless they delete their jdtls installation.
I mean I went through that, users are like +lsp +java in their doom config and if it doesn't work they go to redding/discord. This one got reported like 20 times even though there is pinned issue: https://github.com/emacs-lsp/lsp-mode/issues/2615
Alright, I see what you mean.
I don't have time to look into a user-guided Java update/installation atm, hopefully I'll find the time soon