lsp-java icon indicating copy to clipboard operation
lsp-java copied to clipboard
verified publisher icon emacs-lsp

Lsp java is not properly re-linting/compiling buffers

Open didibus opened this issue 5 years ago • 5 comments

It seems like as I change Java code in a buffer, I don't get an up to date linting. I keep having to run lsp-workspace-restart for it to update, or I need to run the tests.

What is supposed to recompute this? Is it the file watchers? Should it happen as I type? Should it happen on save?

didibus avatar Feb 20 '20 00:02 didibus

I think that it might be a potential regression from https://github.com/emacs-lsp/lsp-mode/pull/1419 . Do you have steps to reproduce? (preferably over hello world application).

yyoncho avatar Feb 20 '20 05:02 yyoncho

Can you test https://github.com/yyoncho/lsp-mode/commit/7ce3ad597b4cbc8523d7c019b6e975a45354e4e3 ? I believe that the issue was that we do not flush delayed changes before sending notifications.

yyoncho avatar Feb 20 '20 06:02 yyoncho

Hum, tried it a little, and it does seem to fix it. I'll try it some more and confirm.

didibus avatar Feb 20 '20 19:02 didibus

I think I found the issue - I will revert part of aforementioned commit

yyoncho avatar Feb 20 '20 19:02 yyoncho

https://github.com/yyoncho/lsp-mode/commit/97e5e4acc08b359610dc34f75ebbad0a6b37baf9 this one should fix the issue.

yyoncho avatar Feb 20 '20 20:02 yyoncho