lsp-haskell icon indicating copy to clipboard operation
lsp-haskell copied to clipboard

Add custom `lsp-clients-extract-signature-on-hover`

Open slotThe opened this issue 1 year ago • 2 comments

It seems like https://github.com/emacs-lsp/lsp-mode/issues/4362 didn't get any traction, so I'm following what was discussed in https://github.com/emacs-lsp/lsp-haskell/issues/151 and am creating an individual PR here instead.

Before: 2024-08-17-144642_1108x206_scrot

After: 2024-08-17-144117_903x177_scrot


Commit Summary

Add custom lsp-clients-extract-signature-on-hover

This fixes a case where a type signature would be broken up over multiple lines, and we only display the first of these.

Fixes: https://github.com/emacs-lsp/lsp-haskell/issues/151 Related: https://github.com/emacs-lsp/lsp-mode/issues/4362 Related: https://github.com/emacs-lsp/lsp-mode/pull/1740

slotThe avatar Aug 17 '24 12:08 slotThe

I wonder if a PR to upstream might get more traction?

michaelpj avatar Aug 26 '24 09:08 michaelpj

This is essentially what https://github.com/emacs-lsp/lsp-mode/pull/1740 was, but that sadly also went nowhere :/

slotThe avatar Aug 27 '24 06:08 slotThe