jupyter icon indicating copy to clipboard operation
jupyter copied to clipboard

Require TRAMP from ob-jupyter

Open johnbcoughlin opened this issue 4 years ago • 3 comments

Fixes #261

johnbcoughlin avatar Jul 13 '20 05:07 johnbcoughlin

But this will load the whole TRAMP package even when the user has no intention to use commands that require TRAMP functions. A nicer thing would be to ask TRAMP developers to add an ###autoload tag to the function tramp-tramp-file-p. But it would take much time until a new TRAMP version will be released. So maybe a better thing to do now would be to add something like this instead of (require 'tramp) in ob-jupyter.el:

(autoload 'tramp-tramp-file-p "tramp" "Return t if NAME is a string with Tramp file name syntax." nil nil)

link0ff avatar Nov 14 '20 18:11 link0ff

Thank you, that's a good point. Updated to use your suggestion.

johnbcoughlin avatar Jul 03 '21 14:07 johnbcoughlin

Shouldn't we have the autoload somewhere closer to jupyter-tramp-file-name-p? For example somewhere in jupyter-tramp.el. Why does it need to be in ob-jupyter.el? The problem doesn't really have anything to do with Org.

nnicandro avatar Nov 18 '21 16:11 nnicandro