`helm-source-locate` in `helm-for-files` shows only basenames instead of full paths

[ncaq]

What happened?

The locate source section in helm-for-files has started displaying only filenames without their directory paths. Previously, the locate results showed full paths including directories.

Expected behavior

The locate source in helm-for-files should display the full paths of files (including directory paths), as it did before and as helm-locate currently does. Without full paths, it's impossible to distinguish between files with the same name located in different directories (like multiple cargo.toml files across different repositories).

occur image

How to reproduce?

1. Run helm-for-files (or a customized version that includes helm-source-locate in its sources list)
2. Enter a filename that exists in multiple directories on your system (e.g., cargo.toml)

The issue appears to be related to the :ff-transformer-show-only-basename parameter. When manually calling helm with this parameter set to nil, the full paths are displayed correctly:

(helm :sources helm-for-files-preferred-list
      :buffer "*helm for files*"
      :ff-transformer-show-only-basename nil)

Helm Version

Melpa or NonGnuElpa

Emacs Version

Emacs-29.1

OS

GNU/Linux

Relevant backtrace (if possible)

Minimal configuration

• [x] I agree using a minimal configuration

[thierryvolpiatto]

ncaq @.***> writes:

What happened?

The locate source section in helm-for-files has started displaying only filenames without their directory paths. Previously, the locate results showed full paths including directories.

Thanks, fixed.

Perhaps I will make a better fix later using helm-sources-for-files-no-basename.

NOTE: At any time you can toggle the behavior with C-].

Expected behavior

The locate source in helm-for-files should display the full paths of files (including directory paths), as it did before and as helm-locate currently does. Without full paths, it's impossible to distinguish between files with the same name located in different directories (like multiple cargo.toml files across different repositories).

occur image

image.png (view on web)

How to reproduce?

1. Run helm-for-files (or a customized version that includes helm-source-locate in its sources list)
2. Enter a filename that exists in multiple directories on your system (e.g., cargo.toml)

The issue appears to be related to the :ff-transformer-show-only-basename parameter. When manually calling helm with this parameter set to nil, the full paths are displayed correctly:

(helm :sources helm-for-files-preferred-list :buffer "helm for files" :ff-transformer-show-only-basename nil)

Helm Version

Melpa or NonGnuElpa

Emacs Version

Emacs-29.1

OS

GNU/Linux

Relevant backtrace (if possible)

Minimal configuration

• [*] I agree using a minimal configuration

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.**>

ncncaq created an issue (emacs-helm/helm#2713)

What happened?

The locate source section in helm-for-files has started displaying only filenames without their directory paths. Previously, the locate results showed full paths including directories.

Expected behavior

The locate source in helm-for-files should display the full paths of files (including directory paths), as it did before and as helm-locate currently does. Without full paths, it's impossible to distinguish between files with the same name located in different directories (like multiple cargo.toml files across different repositories).

occur image

image.png (view on web)

How to reproduce?

1. Run helm-for-files (or a customized version that includes helm-source-locate in its sources list)
2. Enter a filename that exists in multiple directories on your system (e.g., cargo.toml)

The issue appears to be related to the :ff-transformer-show-only-basename parameter. When manually calling helm with this parameter set to nil, the full paths are displayed correctly:

(helm :sources helm-for-files-preferred-list :buffer "helm for files" :ff-transformer-show-only-basename nil)

Helm Version

Melpa or NonGnuElpa

Emacs Version

Emacs-29.1

OS

GNU/Linux

Relevant backtrace (if possible)

Minimal configuration

• [*] I agree using a minimal configuration

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.**>

-- Thierry