evil icon indicating copy to clipboard operation
evil copied to clipboard

Published 20 hours ago • verified publisher icon emacs-evil

ci: Use Eask to test macos and windows

Open jcs090218 opened this issue 10 months ago • 5 comments

Proposed in https://github.com/emacs-evil/evil/issues/1882#issuecomment-2046965282.

jcs090218 avatar Apr 11 '24 07:04 jcs090218

See the test result in https://github.com/jcs-PR/evil/actions/runs/8642721884?pr=1.

jcs090218 avatar Apr 11 '24 07:04 jcs090218

Thanks for the PR @jcs090218 . I installed Eask locally using npm, and checked out your branch of evil. Running make test succeeds on master, and fails on your branch for me, with this in the terminal: image Any idea what Eask is doing differently that might cause this?

tomdl89 avatar Apr 14 '24 11:04 tomdl89

Sorry, the npm version is falling behind the master branch. 😓 I've released a new release 0.9.7. Can you try update to the latest version? Thanks!

jcs090218 avatar Apr 14 '24 23:04 jcs090218

Thanks @jcs090218 - that works now. One other thing - can you delete the Cask file (and any other CI-related old stuff) as part of this PR?

tomdl89 avatar Apr 15 '24 06:04 tomdl89

I've deleted the Cask file. But I don't know if there is other CI-related stuff. 🤔

jcs090218 avatar Apr 15 '24 07:04 jcs090218

@tomdl89 Friendly ping. :)

jcs090218 avatar May 23 '24 06:05 jcs090218

When I rebased onto master and pushed to my fork, mac-os 26.3 and 27.2 have failed: https://github.com/tomdl89/evil/actions/runs/9304711047

tomdl89 avatar May 30 '24 15:05 tomdl89

This is due to the recent changes; see https://github.com/purcell/setup-emacs/issues/48. 🤔

We would either have the tests on the older macOS version (not macos-latest) or exclude them. Excluding them is much simpler. :)

jcs090218 avatar May 30 '24 21:05 jcs090218