evil icon indicating copy to clipboard operation
evil copied to clipboard

evil-scroll-line-down with magit-blame does not always scroll

Open yamanq opened this issue 1 year ago • 2 comments

Issue type

  • Bug report

Environment

Emacs version: 28.2 Operating System: Arch Linux Evil version: 1.15.0 (2ce03d4) Evil installation type: Git (straight.el) Magit version: 30b0deba Graphical/Terminal: Graphical X11 Tested in a make emacs session (see CONTRIBUTING.md): No because magit is also required.

Reproduction steps

  • Start Emacs in a clean environment: emacs -Q
  • Load magit and evil:
(add-to-list 'load-path "/home/myuser/.emacs.d/.local/straight/repos/magit/lisp/")
(add-to-list 'load-path "/home/myuser/.emacs.d/.local/straight/repos/compat/")
(add-to-list 'load-path "/home/myuser/.emacs.d/.local/straight/repos/dash.el/")
(add-to-list 'load-path "/home/myuser/.emacs.d/.local/straight/repos/with-editor/lisp/")
(add-to-list 'load-path "/home/myuser/.emacs.d/.local/straight/repos/evil/")

(require 'magit)
(require 'evil)
  • Open a heavily committed file, like the README.md of this repository

  • M-x magit-blame

  • b (show commits adding lines)

  • C-e or M-x evil-scroll-line-down will both not have visible behavior image

  • Use the arrow keys to scroll down one line (so that the top visible line of the buffer is not a magit blame line) image

  • C-e will now work until the top line is a magit blame line image

Expected behavior

evil-scroll-line-down should scroll down a line.

Actual behavior

evil-scroll-line-down does not scroll down a line

Further notes

Other movement commands work (tested evil-scroll-line-up, evil-scroll-down, evil-scroll-up, evil-scroll-page-down, evil-scroll-page-up)

yamanq avatar Feb 27 '23 04:02 yamanq

evil-scroll-line-down just calls the built-in function scroll-up. If it is not too much hassle, could you please try to reproduce the issue by running

M-: (let (scroll-preserve-screen-position) (scroll-up 1)) RET

instead of M-x evil-scroll-line-down RET, and if that also exhibits the problem, moving the issue to the Magit/Emacs bug trackers?

axelf4 avatar Oct 22 '23 09:10 axelf4

Thank you for narrowing down the bug. I can still reproduce the issue using that eval. However, I cannot report the issue to those repositories at this time.

yamanq avatar Oct 24 '23 16:10 yamanq