evil icon indicating copy to clipboard operation
evil copied to clipboard

Patch to enable lexical-binding and improve evil-delay

Open monnier opened this issue 2 years ago • 6 comments

I pushed to the scratch/evil branch of nongnu.git a patch which enables lexical-binding in all the files and replaces the evil-delay function (which has to work via the awful eval) with an evil-with-delay macro which lets the byte-compiler properly see and compile the code.

monnier avatar Sep 30 '22 21:09 monnier

Cool, sounds interesting. What URL do I git clone?

tomdl89 avatar Oct 01 '22 16:10 tomdl89

Tom Dalziel [2022-10-01 09:50:14] wrote:

Cool, sounds interesting. What URL do I git clone?

git clone --single-branch -b scratch/evil \
          git://git.sv.gnu.org/emacs/elpa.git

or

git remote add -t scratch/evil elpa-scratch \
           git://git.sv.gnu.org/emacs/elpa.git

monnier avatar Oct 01 '22 18:10 monnier

@monnier are you sure that branch is there/accessible? I get

Cloning into 'elpa'...
warning: Could not find remote branch scratch/evil to clone.
fatal: Remote branch scratch/evil not found in upstream origin

tomdl89 avatar Oct 04 '22 21:10 tomdl89

@monnier are you sure that branch is there/accessible? I get

Cloning into 'elpa'...
warning: Could not find remote branch scratch/evil to clone.
fatal: Remote branch scratch/evil not found in upstream origin

Hmm... yeah, that was meant to say

git clone --single-branch -b scratch/evil
git://git.sv.gnu.org/emacs/nongnu.git

or

git remote add -t scratch/evil elpa-scratch \
           git://git.sv.gnu.org/emacs/nongnu.git

-- Stefan "not proud"

monnier avatar Oct 04 '22 22:10 monnier

I've brought this in as a branch on evil and opened a PR, linked. You'll see there are 3 failed tests. Please take a look when convenient - I'm not sure I'll have the time for a while. Cheers

tomdl89 avatar Oct 05 '22 09:10 tomdl89

I've brought this in as a branch on evil and opened a PR, linked. You'll see there are 3 failed tests.

Excellent, thanks

monnier avatar Oct 05 '22 11:10 monnier