void function seq-into in CI for evil on snapshot builds

[jojojames]

Issue type

• Bug report

Environment

CI/Cask/Make/Emacs 29

Emacs version: 29 Operating System: OSX Evil version: Fairly Recent Evil installation type: Melpa Graphical/Terminal: GUI

Reproduction steps

• Start Emacs

Emacs 29/snapshot Clone repo at commit: https://github.com/emacs-evil/evil-collection/commit/232cb104990ab2ce408f40b6e9dccd9eb56ad339

$ cask test

Expected behavior

evil is able to load properly.

Actual behavior

evil fails to load providing failure:

Error: void-function (seq-into)
  mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode -0xc4fdb87c8512f81>))
  debug-early-backtrace()
  debug-early(error (void-function seq-into))
  seq-into("\32" vector)
  edmacro-parse-keys("C-z" nil)
  read-kbd-macro("C-z")
  (let ((old-key (read-kbd-macro (if (boundp 'evil-toggle-key) evil-toggle-key "C-z"))) (key (read-kbd-macro key))) (with-no-warnings (let ((--dolist-tail-- '((evil-motion-state-map evil-emacs-state) (evil-insert-state-map evil-emacs-state) (evil-emacs-state-map evil-exit-emacs-state)))) (while --dolist-tail-- (let ((pair (car --dolist-tail--))) (if (boundp (car pair)) (progn (let ((map (symbol-value (car pair))) (fun (car (cdr pair)))) (if (keymapp map) (progn (define-key map key fun) (define-key map old-key nil)))))) (setq --dolist-tail-- (cdr --dolist-tail--)))))))
  evil-set-toggle-key("C-z")
  (closure (dabbrev-case-distinction dabbrev-search-these-buffers-only t) (sym value) (evil-set-toggle-key value) (set-default sym value))(evil-toggle-key "C-z")
  custom-initialize-reset(evil-toggle-key (funcall #'(closure (dabbrev-case-distinction dabbrev-search-these-buffers-only t) nil "" "C-z")))
  custom-declare-variable(evil-toggle-key (funcall #'(closure (dabbrev-case-distinction dabbrev-search-these-buffers-only t) nil "" "C-z")) "The key used to change to and from Emacs state.\nMust be readable by `read-kbd-macro'. For example: \"C-z\"." :type string :group evil :set (closure (dabbrev-case-distinction dabbrev-search-these-buffers-only t) (sym value) (evil-set-toggle-key value) (set-default sym value)))
  eval-buffer(#<buffer  *load*-269510> nil "/Users/james/.emacs.d/straight/repos/evil-collection/.cask/29.0/elpa/evil-20220518.859/evil-vars.el" nil t)
  load-with-code-conversion("/Users/james/.emacs.d/straight/repos/evil-collection/.cask/29.0/elpa/evil-20220518.859/evil-vars.el" "/Users/james/.emacs.d/straight/repos/evil-collection/.cask/29.0/elpa/evil-20220518.859/evil-vars.el" nil t)
  require(evil-vars)
  byte-code("\302\303!\210\302\304!\210\302\305!\210\302\306!\210\302\307!\210\302\310!\210\302\311!\210\302\312!\210\302\313!\210\302\314!\210\302\315!\210\302\316!\210\302\317!\210\10\203<\0\302\320!\210\11\203D\0\302\321!\210\322\323!\210\324\325!\207" [evil-want-integration evil-want-keybinding require evil-vars evil-common evil-core evil-states evil-repeat evil-macros evil-search evil-ex evil-digraphs evil-types evil-commands evil-jumps evil-maps evil-integration evil-keybindings run-hooks evil-after-load-hook provide evil] 2)
  require(evil)
  eval-buffer(#<buffer  *load*-174914> nil "/Users/james/.emacs.d/straight/repos/evil-collection/evil-collection.el" nil t)
  load-with-code-conversion("/Users/james/.emacs.d/straight/repos/evil-collection/evil-collection.el" "/Users/james/.emacs.d/straight/repos/evil-collection/evil-collection.el" nil t)
  require(evil-collection)
  eval-buffer(#<buffer  *load*> nil "/Users/james/.emacs.d/straight/repos/evil-collection/test/evil-collection-magit-tests.el" nil t)
  load-with-code-conversion("/Users/james/.emacs.d/straight/repos/evil-collection/test/evil-collection-magit-tests.el" "/Users/james/.emacs.d/straight/repos/evil-collection/test/evil-collection-magit-tests.el" nil t)
  load("evil-collection-magit-tests.el" nil t)
  command-line-1(("-L" "." "-L" "./test" "-l" "evil-collection-magit-tests.el" "-f" "ert-run-tests-batch"))
  command-line()
  normal-top-level()
Symbol's function definition is void: seq-into

Example failure: https://github.com/emacs-evil/evil-collection/runs/6663574907?check_suite_focus=true

Further notes

It looks like (require 'seq) is needed at the beginning of evil-vars.

Once I move my require call here: https://github.com/emacs-evil/evil-collection/commit/514494a9973a29f070c5b5c40c05dcb80e724a5f above (require 'evil), tests are able to compile and run but this doesn't seem like the best solution. I've made the change in evil-collection for the time being so the CI doesn't complain anymore but it would be good to fix in evil.

Successful run with my moving the require line above (require 'evil): https://github.com/emacs-evil/evil-collection/actions/runs/2418267454

Not sure why the CI doesn't error on the evil repo.