evil-search doesn't update as you edit, even if you edit a result

[saurik]

Issue type

• Bug report

Environment

Emacs version: GNU Emacs 26.3 (build 2, x86_64-pc-linux-gnu) of 2020-03-26, modified by Debian Operating System: Ubuntu 20.04.1 LTS Evil version: Evil version 1.14.0 Evil installation type: MELPA (?) Graphical/Terminal: mintty (Cygwin terminal, ssh'd to a Linux machine) Tested in a make emacs session (see CONTRIBUTING.md): YES

Reproduction steps

• Start Emacs
• M-x eval-expression RET (evil-select-search-module 'evil-search-module 'evil-search) RET
• use / to search for something; it is now highlighted
• use i to enter insert mode inside of the search result
• type content (including new lines) into the search result

Expected behavior

As you edit the document, new search results should highlight and old search results you modify should stop being highlighted.

Actual behavior

It seems like regions of the document are marked as results at the time of search, and subsequent edits only move the start/end ranges of these results: if you add new results, they are not found; and, even more disconcerting, if you edit inside of a search result (which is what I am intending to do most of the time when I search for something) it remains highlighted as you edit it, even causing the search result highlighting to cross multiple lines as you insert new content inside of the result.