evil-collection icon indicating copy to clipboard operation
evil-collection copied to clipboard

pdf: Add binds for `pdf-history-forward/backward`

Open PRESFIL opened this issue 2 years ago • 9 comments

Brief summary of what the package does

pdf-tools has functions for navigating in jump history. This PR simply adds standard bindings to these functions. The prefix counters are also supported.

Direct link to the package repository

https://github.com/vedang/pdf-tools

Checklist

Assume you're working on mpc mode:

  • [x] byte-compiles cleanly
  • [x] M-x checkdoc is happy. Don't manually write (provide 'evil-collection-mpc), M-x checkdoc can do it automatically for you
  • [x] define evil-collection-mpc-setup with defun
  • [x] define evil-collection-mpc-mode-maps with defconst
  • [x] All functions should start with evil-collection-mpc-

PRESFIL avatar Aug 21 '22 11:08 PRESFIL

I confirm that this works the bindings work without evil-normalize-keymaps for pdf-history-minor-mode. For some reason, the original version doesn't have these hooks for the other minor modes either (pdf-outline-buffer-mode and pdf-occur-buffer-mode-map).

I can add evil-normalize-keymaps if needed, as far as I understand, this should be done for each minor mode separately.

Other things was resolved.

PRESFIL avatar Aug 25 '22 06:08 PRESFIL

Squash yours commits please.

condy0919 avatar Aug 26 '22 18:08 condy0919

Squashed.

PRESFIL avatar Aug 26 '22 23:08 PRESFIL

Looks like no my faults ;)

Snapshot CI failed due deprecation in another file:

In toplevel form:
modes/emms/evil-collection-emms.el:63:16: Error: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ instead.
make: *** [Makefile:11: compile] Error 1
Error: Process completed with exit code 2.

PRESFIL avatar Sep 01 '22 19:09 PRESFIL

@tshu-w Help! pdf-tools needs your tests/contribution!

condy0919 avatar Sep 04 '22 08:09 condy0919

@condy0919 Hey, I'm not using pdf-tools anymore, but I may test this PR when I'm free if needed.

tshu-w avatar Sep 05 '22 01:09 tshu-w

Are we still waiting for the test?

@condy0919, Maybe you can test it yourself?

Installing pdf-tools is not that difficult, apart from the package you need to install AUR's emacs-pdf-tools-git package.

PRESFIL avatar Sep 10 '22 09:09 PRESFIL

Sorry for delay, let me test.

condy0919 avatar Sep 14 '22 16:09 condy0919

Any updates?

PRESFIL avatar Sep 24 '22 05:09 PRESFIL

:rocket:

PRESFIL avatar Sep 26 '22 17:09 PRESFIL