elyra icon indicating copy to clipboard operation
elyra copied to clipboard

Add "what's new" tile to launcher

Open salonee13 opened this issue 3 years ago • 8 comments

Fixes #2795

What changes were proposed in this pull request?

Added a tile in launcher called 'What's new'. It is connected to a link that takes you to the releases page and shows you the latest version of Elyra you have installed.

How was this pull request tested?

I ran make watch and then opened another terminal and ran jupyterlab --watch and was able to edit and view the changes to the launcher to check and see if the tile was there and worked by opening the correct link.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

salonee13 avatar Jul 26 '22 19:07 salonee13

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

elyra-bot[bot] avatar Jul 26 '22 19:07 elyra-bot[bot]

This looks great, thanks for the contribution!

One suggestion I have is that I think it'd be better if the icon was more specific to releases.

  • This is where we've gotten icons in the past: https://carbondesignsystem.com/guidelines/icons/library/ - looks like they have a good icon if you search "release".
  • You'll need to add the svg file for the icon here: https://github.com/elyra-ai/elyra/tree/main/packages/ui-components/style/icons
  • Then you'll need to import it in this file (you can use the other icon imports as an example): https://github.com/elyra-ai/elyra/blob/main/packages/ui-components/src/icons.tsx

Let me know if you need any help with that!

marthacryan avatar Jul 27 '22 15:07 marthacryan

hi, I would like to be assigned to this PR, I would like to add the requested changes

shadowluigi27 avatar Aug 05 '22 18:08 shadowluigi27

@salonee13 - can you add @shadowluigi27 to your list of collaborators like we did for cherry?

akchinSTC avatar Aug 08 '22 15:08 akchinSTC

Absolutely, I just added him as a collaborator.

On Mon, Aug 8, 2022 at 11:34 AM Alan Chin @.***> wrote:

@salonee13 https://github.com/salonee13 - can you add @shadowluigi27 https://github.com/shadowluigi27 to your list of collaborators like we did for cherry?

— Reply to this email directly, view it on GitHub https://github.com/elyra-ai/elyra/pull/2857#issuecomment-1208284299, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWSSEBSWXZ7PXOKEOOYRYKDVYESINANCNFSM54XCH7SQ . You are receiving this because you were mentioned.Message ID: @.***>

salonee13 avatar Aug 08 '22 15:08 salonee13

@salonee13 - awesome! thanks! @shadowluigi27 - you should be able to push your changes now

akchinSTC avatar Aug 08 '22 16:08 akchinSTC

Remember to also update the release script as indicated in this comment. As is the link would always open to the 'latest' release, which isn't necessarily the release the user has installed.

ptitzler avatar Aug 09 '22 08:08 ptitzler

Tile displays version now as well and release script changes are in image

akchinSTC avatar Aug 10 '22 22:08 akchinSTC

The tool tip display seems to randomly switch back and forth between displaying the internal label and the caption ...

2022-08-11_19-07-16 (1)

I'm seeing this behavior pretty consistently. It doesn't seem to happen for other tiles

ptitzler avatar Aug 11 '22 17:08 ptitzler

Test failure and tooltip issue have been resolved. Thx @karlaspuldaro

akchinSTC avatar Aug 12 '22 17:08 akchinSTC