elyra icon indicating copy to clipboard operation
elyra copied to clipboard

Increase coverage of frontend unit tests

Open karlaspuldaro opened this issue 3 years ago • 6 comments

Currently the only packages containing front-end unit tests are pipeline-editor and services. It would be helpful to expand the unit test coverage across all other packages in Elyra, as well as add more tests to existing extensions.

This is an umbrella issue - subtasks can be delivered in separate PRs.

Pipeline Editor

  • [ ] Test Pipeline Service (runtime types, runtimes, runtime images, runtime schema, node types, node paths)
  • [ ] Test runtime utils (runtime data, config details)
  • [ ] Test pipeline dialogs ( submit, export, version, migration, unsupported, clear - linked to issue #687)

Metadata Common (on hold)

Metadata Editor (on hold)

Code Snippets (on hold - metadata related)

  • Test Code Snippet Widget (sorting, search, editor preview, language verification on insert)
  • Test Code Snippet Service (find by language, delete)

Script Editor

  • [x] Test Script Controller (available kernels) (#2576)
  • [x] Test Script Runner (session connection, kernel status/messages, code output/errors)(#2576)

UI Components

  • [ ] Test error dialogs - linked to issue #687

Services

  • [x] Rename outdated test file application.spec.ts(#2523)
  • [ ] Test ContentParser

karlaspuldaro avatar Feb 07 '22 23:02 karlaspuldaro

I'm interested in taking a look at this! I've added a file for PipelineService testing here (#2449), so I can build out that testing first

samali0996 avatar Feb 09 '22 17:02 samali0996

Would also provide me with a good opportunity to understand the frontend components :)

samali0996 avatar Feb 09 '22 17:02 samali0996

Thank you @samali0996 that would be great!

karlaspuldaro avatar Feb 09 '22 19:02 karlaspuldaro

I'm interested in taking a look at the Rename outdated test file application.spec.ts subtask. It shouldn't interfere with Sam's work on PipelineService testing.

kusamkaur16 avatar Feb 22 '22 17:02 kusamkaur16

Since this is an umbrella issue we probably won't complete all subtasks for 3.7 but we can continue the work on the next milestone.

@samali0996 Would you be able to open a PR for the Pipeline Service tests even if it's still in progress?

karlaspuldaro avatar Mar 18 '22 16:03 karlaspuldaro

Hi Could I work on this ! Thanks

vhada7 avatar Jul 15 '22 18:07 vhada7