Hackerank icon indicating copy to clipboard operation
Hackerank copied to clipboard

Link to Github Repo

Open josher19 opened this issue 12 years ago • 1 comments

Nice app!

Couple of issues:

  1. The hacker-repo-name should always link to the github repo. Try this:
hacker.repoUrl=hacker.repoUrl || ["https://github.com", repo.username, repo.name, ""].join("/");

around line 525 of app.js

  1. Sometimes there is an Error message in the console.log:
Uncaught TypeError: Cannot read property 'owner' of undefined

at app.js:515

Might need to guard against this with something like:

repo = repos.shift();
if (!repo) { return; }

or

repo = repos.shift() || {owner:"NOBODY"};

Let me know if you'd like me to put in a Pull Request for these changes.

->> Josh <<-

josher19 avatar Jan 29 '13 05:01 josher19

app/models/search.coffee Lines 22 and 35.

josher19 avatar Jan 29 '13 05:01 josher19