elvish icon indicating copy to clipboard operation
elvish copied to clipboard

edit:complete-dirname doesnt suggest symlinks to directories

Open SolitudeSF opened this issue 1 year ago • 1 comments

What happened, and what did you expect to happen?

edit:complete-dirname doesnt suggest symlinks to directories. it should.

Output of "elvish -version"

0.22.0-dev.0.20240821105340-94dca2081188

Code of Conduct

SolitudeSF avatar Aug 31 '24 10:08 SolitudeSF

side-effect is that complete-filename suggest symlinks to directories as files, without adding trailing slash.

SolitudeSF avatar Sep 02 '24 12:09 SolitudeSF

It would be great to get this fixed...

iandol avatar Nov 10 '24 08:11 iandol

This should be due to fs.FileInfo.IsDir checking the FileInfo of the symlink. There's filepath.EvalSymlinks, but the question is whether to fix this in GenerateDirNames (complex predicate) or generateFileNames (inconsistency as predicate is applied to the resolved stat).

rsteube avatar Dec 01 '24 21:12 rsteube