dotnet-stellar-sdk icon indicating copy to clipboard operation
dotnet-stellar-sdk copied to clipboard

Support network arg for adding signatures to transaction

Open raymens opened this issue 1 year ago • 2 comments

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] I have read the CONTRIBUTING document.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

raymens avatar Mar 08 '23 12:03 raymens

Looks like the test is failing:

Test method stellar_dotnet_sdk_test.TransactionTest.TestAddPreSignedSignature threw exception: 
stellar_dotnet_sdk.NoNetworkSelectedException: Exception of type 'stellar_dotnet_sdk.NoNetworkSelectedException' was thrown.

elucidsoft avatar Mar 09 '23 16:03 elucidsoft

Thanks, I've updated it to default to Network.Current

raymens avatar Oct 11 '23 08:10 raymens