Eugene Lukash

Results 285 comments of Eugene Lukash

then we can make a ga release, I guess. thank you!

Hi @jmoghisi I think I can merge this. Just don't want to reformat/codestyle after merge, so maybe those things can be included (cc @gtnicol). Basically, reformat according to ``` indent_style...

Thank you for update! As I've recently got my broadband internet connection restored, planning to do the long awaited maintenance release over the weekend. Let me know if you think...

i'm doing an 2.9.3 release now, not including this, but expect this to be merged soon after. I'm assuming you're saying it's ready enough (given an uncertainty with some issues).

I'll merge it today, seems we don't have any resources/capacity for diving into any remaining details. As I've mentioned, we will just not advertise it as something stable, will stay...

@gtnicol just some build problems ``` [INFO] ------------------------------------------------------------- Error: COMPILATION ERROR : [INFO] ------------------------------------------------------------- Error: /home/runner/work/immutables/immutables/criteria/sql/src/org/immutables/criteria/sql/commands/SqlCountCommand.java: Internal compiler error: java.util.ServiceConfigurationError: javax.annotation.processing.Processor: Provider org.immutables.generator.processor.Processor could not be instantiated at java.util.ServiceLoader.fail(ServiceLoader.java:232) Error:...

I think we will merge the initial version, given that it is experimental/unstable API and design should be changed around how result mappers and other field mapping works, maybe even...

I was hoping we have such a change under a feature flag. But I cannot find such thing. I might need to look into how it was before and why...

Sorry for delayed response. Sure, if PR would have a feature/style flag and will be able to turn that older sorting, that would be great and will be merged. I...