elsirion

Results 330 comments of elsirion

For HBBFT we got an implementation in the crate that I just need to understand again, for TBS I'd go with [GJKR](https://link.springer.com/content/pdf/10.1007%2F3-540-48910-X_21.pdf) (I think there's a more recent version from...

Maybe just wait/poll till it has the expected value and timeout otherwise?

https://github.com/fedimint/minimint/runs/7360992558?check_suite_focus=true

https://github.com/fedimint/fedimint/actions/runs/3112194306/jobs/5045353221#step:11:6632

Relevant presentation https://www.youtube.com/watch?v=6iz9xCCPNPA

~Oh wow, `rust-bitcoin` upgraded `rand` :tada: if it's only a question of getting `bitcoincore-rpc` upgraded let's fork it till upstream accepts the change?~ Just saw https://github.com/fedimint/fedimint/issues/75#issuecomment-1217267764

> I'll let @elsirion answer, it was his recommendation. I just had both PRs on my radar as "high prio because big", so my thought was that one should build...

This one seems a tiny bit less ready, so merging #600 first. > This one is necessary and please verify the rebase https://github.com/fedimint/rust-secp256k1-zkp/pull/1 . I'll ask Justin to push as...

Just tried to use a kind of global `Box` in `MinimintConsensus`, turns out that doesn't work since our API thread hold a reference to `MinimintConsensus` and it thus needs to...

Also, a commit like "fix lint errors" should just be squashed together with the commit that introduced the error (it's a minor fixup). A later commit should not undo changes...