Michał Siedlaczek

Results 141 comments of Michał Siedlaczek

Note that the above results are incomplete, we should re-run `scan-build` tool to get the full list.

I haven't looked into all of them yet, but a few points: 1. Since the block size is always 128, I'd replace `thread_local std::vector` with `constexpr std::array`, which will also...

@amallia can you weigh in on these?

@amallia Is this something important?

@JMMackenzie When you're talking about overhead, do you mean the overhead of setting up thread pool and such, or also overhead of starting each thread? If I understand correctly, the...

Yes, I believe TBB should do just fine. There are two concurrent queues: one unbounded and one bounded. Since currently all queries are loaded to memory at the beginning anyway,...

Thanks for finding those! Would you maybe want to create a pull request with fixes? :)

That's okay, thanks for pointing these out anyway!

We should modify our `Document_Record` to have a member function like `title` or `id` or something more generic than `trecid`: this would be a (unique?) text identifier of a document....

If you remember, can you clarify "does not work"? The only difference between these two I can see is that the python script lowercases the values. Could that be the...