Michał Siedlaczek

Results 137 comments of Michał Siedlaczek

We've upgraded the docs since this was opened, here's one link of interest: https://pisa.readthedocs.io/en/latest/experiments/regression-robust04.html

I'm closing this in favor of #521

No longer seeing any errors in our code.

Alternatively, here's the diff for "i" aligned with "l": ``` diff --git a/source/Hack-Regular.ufo/glyphs/i.glif b/source/Hack-Regular.ufo/glyphs/i.glif index dbbe950bc..592ff10a4 100644 --- a/source/Hack-Regular.ufo/glyphs/i.glif +++ b/source/Hack-Regular.ufo/glyphs/i.glif @@ -4,38 +4,38 @@ - - - - -...

Here's a preview for the i-shifted-to-align-with-l change (starts with 19px and goes down by one pixel to 10px): ![hacked-black-on-white](https://user-images.githubusercontent.com/3026120/202302133-3f79bebf-6f1e-4925-83fd-48ee4b7256c7.png) ![hacked-white-on-black](https://user-images.githubusercontent.com/3026120/202302137-1e2efa2e-8223-4aae-93c8-9e7ba6f4bd18.png)

I would like to see this feature as well

This is a tricky issue because of efficiency considerations. But if the problem is the stability of of the final sort, how about we add this additional sort condition only...

BTW, I have this PR pending: https://github.com/pisa-engine/pisa/pull/507 where I implement a custom pop-push operation instead of using `std::pop_heap`. We could also implement our own `pop_push` (used only before the heap...

@seanmacavaney FYI, I opned a PR for this, if you'd like to give it a look.