elsa-core icon indicating copy to clipboard operation
elsa-core copied to clipboard

Add dynamic drag-and-drop connections between objects on designer workflows

Open karavajka opened this issue 2 years ago • 1 comments

karavajka avatar Oct 13 '22 13:10 karavajka

@karavajka thank you for this promising PR! I checked it out real quick and although it's not using X6 as Elsa 3 (but jsPlumb), And although I think that's OK, I did notice a few things:

  1. The new designer does not support multiple selection of activities to perform bulk-actions like copy & delete.
  2. While panning, the workflow behaves a bit jumpy and tends to snap to some other location.
  3. When repositioning a node, it oftentimes jumps to a different location than where I released the mouse button.
  4. Some activities like Fork don't expose their configured branches as outcomes (see below screenshot).
  5. I think the green Start button should be removed, or renamed to e.g. "Add Activity".
  6. The styling of activities could use some extra attention - perhaps a bit of padding? Right now, the icon's white border overlaps the outer border of the activity.
image

If you can fix these issues then that would be absolutely wonderful. I am curious however as to what made you go with JsPlumb instead of back-porting the V3 designer using X6, which doesn't have any of these issues?

sfmskywalker avatar Oct 14 '22 19:10 sfmskywalker

Hello, I am also contributing to the development of this feature a bit. About the 6th point, the white overflow is actually part of each of the icon components, given with the class elsa-ring-white. I thought it would be too unsafe to remove it for each of them, so I chose to override the style for the activity component itself. I hope that is acceptable.

tanelkuhi avatar Oct 25 '22 07:10 tanelkuhi

@tanelkuhi Indeed, changing the icon itself would affect the current designer, which we still want to support as an option to users.

I think adding just some padding might be good enough. Alternatively, we could consider refactoring the icon components to make them more configurable.

sfmskywalker avatar Oct 27 '22 12:10 sfmskywalker

@tanelkuhi Indeed, changing the icon itself would affect the current designer, which we still want to support as an option to users.

I think adding just some padding might be good enough. Alternatively, we could consider refactoring the icon components to make them more configurable.

So, these changes, that I did in this commit are not good enough? https://github.com/elsa-workflows/elsa-core/pull/3347/commits/967f156a3f200799acaa010ace5a4ec03fc23a0e

tanelkuhi avatar Oct 28 '22 06:10 tanelkuhi

@karavajka Should we close this PR?

sfmskywalker avatar Nov 16 '22 20:11 sfmskywalker