elsa-core
elsa-core copied to clipboard
Add dynamic drag-and-drop connections between objects on designer workflows
@karavajka thank you for this promising PR! I checked it out real quick and although it's not using X6 as Elsa 3 (but jsPlumb), And although I think that's OK, I did notice a few things:
- The new designer does not support multiple selection of activities to perform bulk-actions like copy & delete.
- While panning, the workflow behaves a bit jumpy and tends to snap to some other location.
- When repositioning a node, it oftentimes jumps to a different location than where I released the mouse button.
- Some activities like Fork don't expose their configured branches as outcomes (see below screenshot).
- I think the green Start button should be removed, or renamed to e.g. "Add Activity".
- The styling of activities could use some extra attention - perhaps a bit of padding? Right now, the icon's white border overlaps the outer border of the activity.

If you can fix these issues then that would be absolutely wonderful. I am curious however as to what made you go with JsPlumb instead of back-porting the V3 designer using X6, which doesn't have any of these issues?
Hello, I am also contributing to the development of this feature a bit.
About the 6th point, the white overflow is actually part of each of the icon components, given with the class elsa-ring-white
. I thought it would be too unsafe to remove it for each of them, so I chose to override the style for the activity component itself. I hope that is acceptable.
@tanelkuhi Indeed, changing the icon itself would affect the current designer, which we still want to support as an option to users.
I think adding just some padding might be good enough. Alternatively, we could consider refactoring the icon components to make them more configurable.
@tanelkuhi Indeed, changing the icon itself would affect the current designer, which we still want to support as an option to users.
I think adding just some padding might be good enough. Alternatively, we could consider refactoring the icon components to make them more configurable.
So, these changes, that I did in this commit are not good enough? https://github.com/elsa-workflows/elsa-core/pull/3347/commits/967f156a3f200799acaa010ace5a4ec03fc23a0e
@karavajka Should we close this PR?