Bug in BookmarkFinder

[Alexplose]

Bookmarks are created in database with activity type like SignalReceived

But the method Findbookmark uses GetSimpleAssemblyQualifiedName(), that return something like : Elsa.Activities.Signaling.SignalReceived, Elsa.Core.

So FindBookmark return empty results, because SignalReceived doesn't match Elsa.Activities.Signaling.SignalReceived, Elsa.Core

https://github.com/elsa-workflows/elsa-core/blob/87c44e183c4d488b8df0ee105651f15f0b270a74/src/core/Elsa.Abstractions/Extensions/BookmarkFinderExtensions.cs#L21

[Alexplose]

Could you please revert to the previous version ?

[sfmskywalker]

Revert what exactly from which version to what previous version? Are you referring to a commit or entire package versions?

[Alexplose]

I had to rollback to v2.4.2, when FindBookmarks was using typeof(T).Name

https://github.com/elsa-workflows/elsa-core/blob/b893006c968484ed8a4540d80fa8b0331142b991/src/core/Elsa.Abstractions/Extensions/BookmarkFinderExtensions.cs#L17

I saw that typeof(T).Name has been changed to typeof(T).GetSimpleAssemblyQualifiedName() elsewhere, but I don't know the perimeter of this issue.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sfmskywalker]

Got it. Although we can't just undo this change as it would then break users using the new bookmark names, what we might do is look for both names.

This would be a bit of work, but unless deleting database records is an option, we should do it.

[Alexplose]

I'm stuck using the version 2.4.2. Also it's already broken, the bookmarks are created with the simple type(T).Name, but FindBookmark uses GetSimpleAssemblyQualifiedName(), so all created bookmarks since the breaking version, can't be found with the bookmarkfinder.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.