icon-brew icon indicating copy to clipboard operation
icon-brew copied to clipboard

Create cron job to compress all the icons into one .zip file on a regular basis

Open elrumo opened this issue 1 year ago • 5 comments

elrumo avatar Jul 17 '22 19:07 elrumo

Strapi documentation: https://docs.strapi.io/developer-docs/latest/setup-deployment-guides/configurations/optional/cronjobs.html#creating-a-cron-job

elrumo avatar Jul 18 '22 08:07 elrumo

Wouldn't a GH Action based on PR, merge or release be better than a cronjob? E. g. https://github.com/marketplace/actions/zip-release

janbrasna avatar Nov 01 '22 23:11 janbrasna

Wouldn't a GH Action based on PR, merge or release be better than a cronjob? E. g. https://github.com/marketplace/actions/zip-release

It would, the only issue is that I would need to remember to also upload the icons to GH each week, which I know I would forget. So I think a cronjob that fetches all the icons from the API, creates a ZIP and then pushes it to gh would make more sense. But I'm open to suggestions.

Also, the only reason I haven't done it yet is time. Now that I've added an icon suggestion system, I'll make this a top priority.

elrumo avatar Nov 02 '22 12:11 elrumo

Ah sry, I wrongly inferred that the repository is the source of the actual icon assets, and they are just deployed from here to the site via the Nuxt build+deploy flows. If the "single point of truth" for the icon files is elsewhere, then please disregard my comment;)

janbrasna avatar Nov 10 '22 18:11 janbrasna

No worries, I did consider using GitHub as the single point of truth, but it's not flexible enough and would be quite hard to add metadata like categories and tags which it uses for search. I'm using Strapi for the backend and to host the icons and its relations. The website itself is hosted on Vercel and is the code you see on GitHub. I'm trying my best to remember to upload the icons on GitHub too. And thanks for the support too! 😁

elrumo avatar Nov 11 '22 10:11 elrumo