Results 238 comments of El RIDO

Thank you, it checks out and did increase our code coverage. For that particular function there is not much more to test. Many of those TopNav functions simply hide or...

@ankiiisharma Weirdly, your new test did pass on the machine I tested it on, but failed when running the full test suite in github actions. Digging in, I realized that...

I think they are fine for now and you can certainly move on and go for another one. I'll now again better understand what to look for when reviewing these....

Sure thing, go for it. It should not be too complicated, the filename is the first thing generated in the [TopNav.downloadText](https://privatebin.info/jsdoc/TopNav.html#.downloadText) method: https://github.com/PrivateBin/PrivateBin/blob/28f3e544b8543e8777e92ba23ed142b66407673b/js/privatebin.js#L3825-L3834 You could look up the current format...

You have the option to retry the password multiple times, there is a retry button and dialogue informing about it: ![PrivateBin password retry](https://github.com/PrivateBin/PrivateBin/assets/1017622/39faec75-3523-4b62-b560-066e1f1ef9a9) An eye-button (password display) is arguably introducing...

For what it's worth, we _do not_ "have a big maintenance burden by maintaining the page template", IMHO. It doesn't use any extra JS-libraries and extra code paths in JS...

Just noticed that this is already tracked in #265.

So, having re-read the tutorial several times, now... We do provide all the licenses in one file, where github can find it and people expect it, including a short explanation...