Erik Moeller
Erik Moeller
Thanks @lorenwest! I've responded to your inline comment as well. If the code passes the smell test, I'll look into adding tests now that this is a more complex setting,...
No problem, thanks for the late night review. :) I figured it was a relatively safe name change if it's properly announced, but I can change it back. Will add...
Done, let me know if these tests make sense to you. I took the liberty of removing an unnecessary assignment from the previous batch for consistency.
Thanks! Oh boy, it's been a while, will need to stare at this for a little before I can meaningfully test & rebase it - will try to poke at...
I'd be happy to take a crack at a PR implementing the logic in the comment by @markstos above if nobody is already working on this. I use `pm2` and...
Done, let me know if this looks good. I would suggest to maybe parse the two environment variables SUPPRESS_NO_CONFIG_WARNING and NODE_CONFIG_STRICT_MODE using the same logic -- right now, strict mode...
I'm not using the patch (still using a workaround in my setup), so no promises. :) If @lorenwest or @markstos can commit to helping get this across the finish line...
If I understand correctly my problem is different from yours. In my case, `NODE_APP_INSTANCE` is sometimes set by the process manager `pm2` to values that don't resolve to config files,...
While gpgsync does a good job hiding the fragility of the keyserver ecosystem, if this change would enable an org like ours to deprecate use of keyservers entirely, I think...
One slightly fancier version of this might be to add a string like "(translation preview)" in the menu to languages that aren't official yet, to avoid folks wondering why they...