js-sky-sim icon indicating copy to clipboard operation
js-sky-sim copied to clipboard

Wrong timezone conversion to radian

Open pham-tuan-binh opened this issue 4 years ago • 1 comments

I believe you forgot to multiply the timezone by 15 before converting it to radian.

Line 164 in sky-sim.html: var time_zone_meridian = deg2rad(parseFloat($('#tz_sm').val()));

There were also some unused variables in your code, like "tz_offset", which I believe was faulty because of the wrong timezone calculation.

Anyway, super kudos for your amazing project.

pham-tuan-binh avatar Dec 28 '20 11:12 pham-tuan-binh

If you have a tested patch / pull request, I'd appreciate it! I wrote this for one art project and haven't really touched it since.

elonen avatar Dec 28 '20 11:12 elonen