OrganizrInstaller icon indicating copy to clipboard operation
OrganizrInstaller copied to clipboard

Published 20 hours ago • verified publisher icon elmerfds

Important fixes

Open WarningImHack3r opened this issue 3 years ago • 2 comments

This PR does

  • Fix ambigous (and dangerous) behavior during uninstall
  • Global fix for shell formatting
  • Small refactors
  • Fix unhandled cases in yes/no questions
  • Handle uninstallation for certbot via snap or apt

Some notes

  • These changes should probably be applied to CentOS script too. You can use ShellCheck to look for stuff to change, and/or copy the ones I made.
  • There seem to be some other things to remove, such as crontab entry as I've seen, but I didn't dig enough into the script to be sure.
  • And please, never delete folders that may contain anything other than the targeted program, such as important folders like /var/www. If you cannot be sure it won't affect anything else, let the user do it themselves.
    I've lost all my existing websites and certbot certificates because of this script, while it was vaguely mentioning "Web folder" and "Letsencrypt folder". (Fortunately, I kept some recent backups)

WarningImHack3r avatar Jan 04 '22 19:01 WarningImHack3r

@elmerfdz you around to merge this PR?

causefx avatar May 20 '22 21:05 causefx

@WarningImHack3r can you open a PR for this @ https://github.com/Organizr/OrganizrInstaller since we just forked it to maintain it there.

causefx avatar May 20 '22 22:05 causefx

@causefx done. (Sorry I wasn't logged into this account for a while)

WarningImHack3r avatar Sep 23 '22 09:09 WarningImHack3r

checking now

causefx avatar Sep 28 '22 19:09 causefx