Guillaume Potier
Guillaume Potier
@aatifsyed Kind of, one issue we had in the past was with some tasks that were deadlocking and also other that were not joined properly. Those sticking tasks would hinder...
> We were hitting errors where spawned tokio tasks were panicking, presumably throwing up backtraces that no-one would see No that did not happen, but I choose defensive code and...
> And it would be more idiomatic to bubble up panics in spawned tasks, which is the refactor you're suggesting? Yes, but that's probably a quite involving task.
I've created a dedicated issue for `Filecoin.EthGetBlockByNumber`. The PR is already significant, and `EthGetBlockByHash` is not straightforward.
Blocked by #4759
> Can we have unit tests for this implementation? Sure.
@ruseinov Not too fast, buster!
@LesnyRumcajs added a few unit tests to cover the most intricated functions
Yes, that works, but a scalar is also possible instead of a list.
@sudo-shashank I've changed `EthHashList` in #4780 to ease the pain for the topic matcher.