parser icon indicating copy to clipboard operation
parser copied to clipboard

No implementation for deadEndsToString

Open jdmnd opened this issue 6 years ago • 8 comments

https://github.com/elm/parser/blob/master/src/Parser.elm#L170 The documentation implies a basic working implementation, but currently it's just a placeholder:

deadEndsToString deadEnds =
  "TODO deadEndsToString"

jdmnd avatar Aug 26 '18 20:08 jdmnd

I've created a PR with a proposed implementation for this function. All comments welcome.

blawlor avatar Dec 31 '18 14:12 blawlor

I too have a PR for this issue, which has been sitting since september!

bburdette avatar Dec 31 '18 14:12 bburdette

Hi @bburdette - I didn't see your PR on this ticket. If I had I would happily just have used your fork!

blawlor avatar Jan 01 '19 10:01 blawlor

Ok - I see what happened. Your PR is associated with a closed duplicate (#16 ) of this issue. Anyhoo - to the commiter(s) on this project, please use @bburdette 's PR over mine.

blawlor avatar Jan 01 '19 10:01 blawlor

Its ok with me either way! Would be nice for this to get merged sometime though. Maybe a major revision of the lib is waiting in the wings though.

bburdette avatar Jan 01 '19 18:01 bburdette

https://elmlang.slack.com/archives/C0CJ3SBBM/p1557003208085000?thread_ts=1557003208.085000&cid=C0CJ3SBBM

andys8 avatar May 05 '19 11:05 andys8

Same as above but copied into a gist for folk reading this in more than two weeks time: https://gist.github.com/harrysarson/234436a9f0517e14d0fd67fd63ba6619

harrysarson avatar May 05 '19 13:05 harrysarson

Yikes. Still just a TODO...

Erudition avatar Jul 15 '19 22:07 Erudition