parser icon indicating copy to clipboard operation
parser copied to clipboard

Published 20 hours ago • verified publisher icon elm

implementation deadEndsToString

Open YuichiMorita opened this issue 5 years ago • 4 comments

simple implementation deadEndsToString function

YuichiMorita avatar Dec 07 '19 02:12 YuichiMorita

This is a duplicate of #16

brianvanburken avatar Dec 07 '19 07:12 brianvanburken

I like this version, with the row and col position. Nice!

bburdette avatar Dec 09 '19 14:12 bburdette

@brianvanburken, it is desirable to have multiple issues or PRs about a topic.

  • With issues, having more examples makes it easier to figure out. Having many examples in a single thread makes it very mentally difficult to disentangle when there are three or four different root, so "duplicates" is actually way nicer to work with in my experience! This is also a good way to gauge "how often is this discovered independently?" and does not put an unreasonable burden on reporters to be super informed about everything going on in other issues.
  • With PRs, you get similar benefits. Seeing different perspectives on how to fix something only helps!

Point is, I like to have "duplicates" on my projects! I hope this doesn't sound like a reprimand. I just need to tell people about this because it is not the norm!

evancz avatar Dec 09 '19 17:12 evancz

Hey @evancz, are you reviewing this pull request? I just tried using this feature and got "TODO deadEndsToString". Even a simple implementation like this one would be a huge improvement.

joshuakb2 avatar Jan 16 '20 00:01 joshuakb2