html icon indicating copy to clipboard operation
html copied to clipboard

video attributes missing

Open kwijibo opened this issue 7 years ago • 5 comments

Hi, I noticed these <video> attributes are missing from the Attributes module:

  • crossorigin
  • mediagroup
  • muted https://www.w3.org/TR/html5/embedded-content-0.html#the-video-element

Would you be interested in a PR?

kwijibo avatar Nov 21 '17 15:11 kwijibo

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

process-bot avatar Nov 21 '17 15:11 process-bot

muted is also missing for audio.

RobertSwirsky avatar Dec 15 '17 20:12 RobertSwirsky

Workaround: Html.Attributes.attribute "muted" ""

nqthqn avatar Dec 26 '17 20:12 nqthqn

@nqthqn your solution does not work with the autoplay property for videos

working workaround property "muted" (Json.bool True)

This solution is working with the autoplay policy from chrome.

The muted property is sometimes visible and sometimes not but magically it's working

I will add a PR to extend the module with muted function

Paryz avatar Sep 02 '19 22:09 Paryz

https://github.com/elm/html/blob/master/properties-vs-attributes.md

nqthqn avatar Sep 03 '19 17:09 nqthqn