elm-language-server icon indicating copy to clipboard operation
elm-language-server copied to clipboard

Disallow renaming to reserved or existing symbols

Open bengolds opened this issue 4 years ago • 2 comments

In 1.7, guards were added to prevent users from renaming certain reserved symbols -- you can't rename let or if to something else and you can't rename values imported from packages.

The reverse of this might be handy as well -- not allowing you to rename a symbol to let, or in. It might be nice to also check to see if that symbol is already taken. For example:

foo = 3

bar = 4
-- rename would disallow renaming bar to
--   if, let, else, then, type, alias, module, exposing, and any other keywords
--   foo, since it already exists.

bengolds avatar Apr 02 '20 18:04 bengolds

@Razzeee can I work on this issue, if its not taken?

starboi02 avatar Mar 27 '21 11:03 starboi02

Yes, please go ahead

On Sat, Mar 27, 2021, 12:34 Varun Bhardwaj @.***> wrote:

@Razzeee https://github.com/Razzeee can I work on this issue, if its not taken?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elm-tooling/elm-language-server/issues/248#issuecomment-808718368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNLEZHSG5PUYZHVBI2B5CDTFW7DNANCNFSM4L2X7SZA .

razzeee avatar Mar 27 '21 13:03 razzeee