elm-language-client-vscode icon indicating copy to clipboard operation
elm-language-client-vscode copied to clipboard

meta.record.field.update.elm property missing in elm record update assignment

Open eimfach opened this issue 5 years ago • 4 comments

This may not belong into this repository, I am not sure about that..

I am creating a theme for vscode and wondered, why only the first entry of an elm record update assignment has the property 'meta.record.field.update.elm' and all others have 'meta.record.field.elm' ? Using 'meta.record.field.elm' to style all entries of the record update the same way, clashes with other syntax, like record type aliases, which I did want to style differently ...

Greetings from Berlin !

Bildschirmfoto 2020-02-01 um 03 01 15 Bildschirmfoto 2020-02-01 um 03 01 29

eimfach avatar Feb 01 '20 02:02 eimfach

Hey, seems like a bug. I pretty much only inherited the Syntax file. And there is a new way to do coloring in the language server on the horizon, so I'm mostly waiting for that to land.

On Sat, 1 Feb 2020, 03:06 Robin Gruenke, [email protected] wrote:

This may not belong into this repository, I am not sure about that..

I am creating a theme for vscode and wondered, why only the first entry of an elm record update assignment has the property 'meta.record.field.update.elm' ?

[image: Bildschirmfoto 2020-02-01 um 03 01 15] https://user-images.githubusercontent.com/6602910/73585259-cdb68080-449f-11ea-8af9-bab175b7f056.png

[image: Bildschirmfoto 2020-02-01 um 03 01 29] https://user-images.githubusercontent.com/6602910/73585261-cf804400-449f-11ea-88af-5813d55124e5.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/elm-tooling/elm-language-client-vscode/issues/74?email_source=notifications&email_token=ABNLEZGSQIVMHF65LJXUWKLRATKKHA5CNFSM4KOQDPSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKJOCQA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNLEZCQSHWICMCYQA4Q6ZLRATKKHANCNFSM4KOQDPSA .

razzeee avatar Feb 01 '20 09:02 razzeee

Can you create an example repo for this bug? I'm struggling to get the same problem.

image

razzeee avatar Feb 03 '20 08:02 razzeee

You're already close... create an entry for 'meta.record.field.update.elm', give it a color ...

eimfach avatar Feb 03 '20 15:02 eimfach

After looking at this a bit, it seems like meta.record.field.elm is the scope that has been designed to capture this. Is there any rational to not use that?

razzeee avatar Feb 16 '20 22:02 razzeee