elm-language-client-vscode icon indicating copy to clipboard operation
elm-language-client-vscode copied to clipboard

Definitions/references should work in non-writable modules

Open jmbockhorst opened this issue 4 years ago • 2 comments

It can be really helpful to follow code back to the sources even when going through non-writable modules. We should allow this.

jmbockhorst avatar Nov 17 '20 14:11 jmbockhorst

It actually happens here: https://github.com/elm-tooling/elm-language-client-vscode/blob/2a250cb5661fb78c71d01628fac8a80b7949ce8a/client/src/extension.ts#L154

jmbockhorst avatar Feb 20 '21 04:02 jmbockhorst

Just removing that line seems like it works. But also shows some problems, when Kernel modules are loaded. There might be more problems, but I only tested the spa-example, which only has: "NoRedInk/elm-json-decode-pipeline": "1.0.0", "rtfeldman/elm-iso8601-date-strings": "1.1.0" that don't rely on kernel code

razzeee avatar Apr 16 '21 22:04 razzeee

Fixed in https://github.com/elm-tooling/elm-language-client-vscode/commit/ee4eea363f85fb9ecbca4a44a07f57963114dc3f.

jmbockhorst avatar May 13 '23 03:05 jmbockhorst